Core/Auras: Corrected logic used to determine if a spellmod should affect another spell, empty family name or class mask should not apply to any spell

Port From (https://github.com/TrinityCore/TrinityCore/commit/3f479399695ce4aed7f508be46cfdccfd4353eee)
2021-03-29 16:06:26 -04:00
parent 3d40c868f6
commit c1fb79b086
1 changed files with 3 additions and 1 deletions
@@ -668,7 +668,9 @@ namespace Game.Spells
            if (affectSpell == null)
                return false;

-            return IsAffected(affectSpell.SpellFamilyName, mod.mask);
+            // TEMP: dont use IsAffected - !familyName and !familyFlags are not valid options for spell mods
+            // TODO: investigate if the !familyName and !familyFlags conditions are even valid for all other (nonmod) uses of SpellInfo::IsAffected
+            return affectSpell.SpellFamilyName == SpellFamilyName && mod.mask & SpellFamilyFlags;
        }

        public bool CanPierceImmuneAura(SpellInfo auraSpellInfo)