Commit Graph

1597 Commits

Author SHA1 Message Date
hondacrx fc49a98dab Scripts/SmartAI: SMART_TARGET_INVOKER cleanup step 1. The core will now log errors on start-up if SMART_TARGET_INVOKER abuse is found, but will continue to load the scripts as deprecated for now.
Port From (https://github.com/TrinityCore/TrinityCore/commit/06b5b8d8b7ac3da65013ccc0f03599ee9dee2163)
2021-06-23 22:41:44 -04:00
hondacrx de6b8b0240 Core/Spell: Properly remove REACT_PASSIVE on permanent feign death unapply.
Port From (https://github.com/TrinityCore/TrinityCore/commit/ffce2c1f9a416eddad2e45ab2e03df964d5e39cd)
2021-06-23 22:33:07 -04:00
hondacrx 9af3e3adf2 Core/Movement: followup
Port From (https://github.com/TrinityCore/TrinityCore/commit/cecb91ad3d77d622a3b36d36e06a9220b2c44204)
2021-06-23 22:31:04 -04:00
hondacrx fbec933705 Core/Unit: kill unused parameter from SpellxxxBonusTaken
Port From (https://github.com/TrinityCore/TrinityCore/commit/15810eb579c40ee2b3db35ef2a99b7c5cb70c985)
2021-06-23 22:27:20 -04:00
hondacrx 9846d3de7f Core/Unit: corrected calculation for SPELL_AURA_MOD_DAMAGE_TAKEN/SPELL_AURA_MOD_HEALING auras
Port From (https://github.com/TrinityCore/TrinityCore/commit/bc6b0c519776ff6afad586d31b99abd1e9c41678)
2021-06-23 22:22:57 -04:00
hondacrx 2025498ea6 Core/Spells: Do not apply SpellModOp::CritChance to spells that can't crit
Port From (https://github.com/TrinityCore/TrinityCore/commit/18780206bc6470e5a3c1adf4f917766fedbd1c17)
2021-06-23 22:14:39 -04:00
hondacrx 1be1a5ad1a Core/Spells: add log on load about improper use of attribute PROC_ATTR_REQ_SPELLMOD
Port From (https://github.com/TrinityCore/TrinityCore/commit/3582bacc4a3550725d288b55fb16311dee0ae0df)
2021-06-23 22:13:19 -04:00
hondacrx 1b87be93be Core/Spells: implement SPELLVALUE_CRIT_CHANCE
Port From (https://github.com/TrinityCore/TrinityCore/commit/13be704cb4619ef585ae0043580e2534f62e64aa)
2021-06-23 22:09:38 -04:00
hondacrx 9e23ca4b04 Core/Spells: calculate crit chance only for spells that do damage/healing
Port From (https://github.com/TrinityCore/TrinityCore/commit/85e5509e91a1370b16851d375a26121797870921)
2021-06-23 22:06:49 -04:00
hondacrx 89586e9495 Core/AI: EscortAI init logic moved from JustAppeared to InitializeAI. There are no escort NPCs using compatibility mode anymore, so this is equivalent.
Port From (https://github.com/TrinityCore/TrinityCore/commit/f4cc76063f5c19773e25eaac9bd3975828c4cc47)
2021-06-23 18:03:42 -04:00
hondacrx dcf8c12e5c Core/Movement: WaypointMovementGenerator cleanup
Port From (https://github.com/TrinityCore/TrinityCore/commit/6d79b329acd7ad1d81f1f508726f5fad78b70b0e)
2021-06-23 18:02:44 -04:00
hondacrx ca1afb5c2e Core/Movement: Creatures' idle movement generator can no longer override player mover control.
Port From (https://github.com/TrinityCore/TrinityCore/commit/88c1739e3e1ecf58407b0846f3c8dfeb589f3113)
2021-06-23 17:50:46 -04:00
hondacrx 11cbb26bc1 Core/Auras: fix periodic ticks proc after previous commit
Port From (https://github.com/TrinityCore/TrinityCore/commit/c21dc3c1b7985cbffaaf1cd17a48bddd2106154d)
2021-06-23 17:42:38 -04:00
hondacrx 0daea24b3f Core/Spells: require phasemask set for periodic damage procflag
Port From (https://github.com/TrinityCore/TrinityCore/commit/91fa279bdf67646ab15601ec18096c0a45133ebf)
2021-06-23 17:40:28 -04:00
hondacrx f959a0fd91 Core/Spells: fix logic error causing near teleports to drop combat for players
Port From (https://github.com/TrinityCore/TrinityCore/commit/8c379e920ca184d520c81ada26c42c5dfeac770d)
2021-06-23 16:02:44 -04:00
hondacrx 9d3cd6a6e5 Core/Spells: fix logic error causing near teleports to drop combat for players
Port From (https://github.com/TrinityCore/TrinityCore/commit/f9b14ca795de932746ce404dfe56c5cded3bde2b)
2021-06-23 15:59:06 -04:00
hondacrx abee68a7ee Core/Spells: remove duplicated LowerPlayerDamageReq call on reflected spells
Port From (https://github.com/TrinityCore/TrinityCore/commit/800d92bec3b7a771f6fbd8d123dc727c54becd4b)
2021-06-23 15:54:43 -04:00
hondacrx 1aa375a8ee Misc updates 2021-06-23 15:53:42 -04:00
hondacrx 619c79e7f1 Core/Spells: fix SPELLMOD_DAMAGE application order for melee spells
Port From (https://github.com/TrinityCore/TrinityCore/commit/d34292534c197887cd33c15ff98ca8c96dc4fb99)
2021-06-23 15:43:29 -04:00
hondacrx b012517079 Core/Spells: kill unused parameter from Spell constructor
Port From (https://github.com/TrinityCore/TrinityCore/commit/01d9306854618bb66f79e1f0f5d9781ff48ab019)
2021-06-23 15:37:52 -04:00
hondacrx 65173c19cb AI/SmartAI: Remove a silly incorrect piece of code that was breaking react state swaps on SAI creatures.
Port From (https://github.com/TrinityCore/TrinityCore/commit/7695784fd2416764f3efa5bad3529250a49d05c8)
2021-06-23 15:31:17 -04:00
hondacrx 51a6d72fd4 Spell/Script: Torch 52953 and 58121 must hit only one target
Port From (https://github.com/TrinityCore/TrinityCore/commit/854abdbfb6ea1075fbe5db09c1ce70aa2bdb18a8)
2021-06-23 15:30:08 -04:00
hondacrx 737507d718 Core/Creature: Adjust SelectVictim behavior.
Port From (https://github.com/TrinityCore/TrinityCore/commit/95fb6fe075f0cac7bc1822c7b5a0276a2276d897)
2021-06-23 15:29:09 -04:00
hondacrx d6f8baae30 Scripts/Pets: Mirror Image re-write, because it's a colossal mess right now.
Port From (https://github.com/TrinityCore/TrinityCore/commit/39dff738e184a9da2644f140e20083fa3a4cbeb5)
2021-06-23 15:27:54 -04:00
hondacrx 7cbfcf9949 Combat/Threat: Now set engaged state for all units on offline reference registration (vanished/invis'd units). For non-PASSIVE units, this will immediately cause an evade.
Port From (https://github.com/TrinityCore/TrinityCore/commit/fdc1c5b6c952262f98f15f35dcf19fe293c65d5b)
2021-06-23 15:14:51 -04:00
hondacrx f070f7a408 Game/AI: Remove some unused old logic.
Port From (https://github.com/TrinityCore/TrinityCore/commit/75a3b2f122f04a70f3e9eeed21cbe71d131c425f)
2021-06-23 15:13:21 -04:00
hondacrx 3f5ac71ff0 Core/Creature: add an assertion to guard against infinite loops
Port From (https://github.com/TrinityCore/TrinityCore/commit/cb3a041482626a8aa3545a6bc35abd9dfb88cf73)
2021-06-23 15:12:20 -04:00
hondacrx 44cfe32b50 Misc fixes 2021-06-23 15:09:41 -04:00
hondacrx 7a8b37421b Scripts/Commands: new command '.debug instancespawn'
Port From (https://github.com/TrinityCore/TrinityCore/commit/386ec582334818bb46582290e9daecb19f453897)
2021-06-23 15:02:48 -04:00
hondacrx 22c57b92db Core/Spell: killed deprecated code which randomly changed powercost for missed spells
Port From (https://github.com/TrinityCore/TrinityCore/commit/c43f61df3d1612bfe87f2df499e2687c87cb1208)
2021-06-23 14:43:49 -04:00
hondacrx e8b7f00161 Core/Player: only call _ApplyWeaponDamage for actual weapons
Port From (https://github.com/TrinityCore/TrinityCore/commit/905112b2a61c5b3999f936d957e10a3ee6258751)
2021-06-23 14:42:03 -04:00
hondacrx a34469c171 Core/Entities: don't allow client control if player is still affected by any lose of control state
Port From (https://github.com/TrinityCore/TrinityCore/commit/d0f4310c4417fb5dc8e89061adf4ce113caa4227)
2021-06-23 14:39:59 -04:00
hondacrx 84d05548f2 Core/Entities: killed Creature::SetInCombatWithZone and replaced with AI version
Port From (https://github.com/TrinityCore/TrinityCore/commit/c77925da4a320df5be5eaeb1fc799df50e22c041)
2021-06-23 14:15:43 -04:00
hondacrx 0c527d206c Core/Entities: don't allow client control if player is still affected by any lose of control state
Port From (https://github.com/TrinityCore/TrinityCore/commit/29bfa32fc39de1d93fbdb272d48689174c547725)
2021-06-23 14:13:31 -04:00
hondacrx 87cc42ee48 Core/PlayerAI: perform cast checks on auto ranged attack
Port From (https://github.com/TrinityCore/TrinityCore/commit/b46d899ef16ce15e1f8403be076993545035cddc)
2021-06-23 14:08:27 -04:00
hondacrx 0b0ab3b059 Core/Unit: fixed Global cooldown cancelation on spell interrupt
Port From (https://github.com/TrinityCore/TrinityCore/commit/df585571f108b3c44d3db1ab82683151f798cbf7)
2021-06-23 14:06:43 -04:00
hondacrx ad2d0f912e Core/Formations: update codestyle and fix crash
Port From (https://github.com/TrinityCore/TrinityCore/commit/861cf261c5dfc29d6980908ec36ebe7aad68a462)
2021-06-23 14:05:41 -04:00
hondacrx b7f1a6384a Core/Spells: fix Spirit of Redemption
Port From (https://github.com/TrinityCore/TrinityCore/commit/0c56ec914f5f6b55251a7a8889b61ef93d56c924)
2021-06-23 13:33:15 -04:00
hondacrx 047121b31b Core/Unit: Remove a superfluous threat state update in SetPhaseMask.
Port From (https://github.com/TrinityCore/TrinityCore/commit/14bda72751a1164af055ec04e4f4c928df4c3e65)
2021-06-23 13:32:27 -04:00
hondacrx f7e09403ec Core/Threat: Assistance threat (healing, buffs, etc.) is now properly split (instead of copied) between all creatures threatened by the action. Thanks to Foereaper for help with testing, and my apologies to healers everywhere.
Port From (https://github.com/TrinityCore/TrinityCore/commit/73bf0e3a0b1f93d8dab719194b4aa5bf746cb969)
2021-06-23 13:31:01 -04:00
hondacrx 9631f569fa Core/Threat: Passive creatures now properly become engaged when adding an offline threat entry. Fixes RoS and Thaddius, maybe more.
Port From (https://github.com/TrinityCore/TrinityCore/commit/9f91cf23ab8ab5f4fe35cba2e504d299248c4e60)
2021-06-23 13:29:40 -04:00
hondacrx 0e8d21bae9 Core/Auras: Don't remove shield only dependant auras on disarm
Port From (https://github.com/TrinityCore/TrinityCore/commit/)
2021-06-23 13:25:19 -04:00
hondacrx 7eed87f51c Core/Auras: define and implement attribute SPELL_ATTR3_NO_PROC_EQUIP_REQUIREMENT
Port From (https://github.com/TrinityCore/TrinityCore/commit/b27e741096b59d3e07503bb8db30df6596dee1f2)
2021-06-23 13:22:42 -04:00
hondacrx 62119923f2 Core/Scripts: added null checks to DamageTaken hooks
Port From (https://github.com/TrinityCore/TrinityCore/commit/62c571076e5319c07c7222e139dbfc7c8bb4543f)
2021-06-23 12:15:38 -04:00
hondacrx dd4d434d72 Scripts/Spells: quest "That's Abominable"
Port From (https://github.com/TrinityCore/TrinityCore/commit/6d7288356a5de88df1636916d5f2d4f1c37aff4b)
2021-06-23 12:13:15 -04:00
hondacrx 1cebd025fe Core/CombatAI: Npcs with TurretAI will be able to attack again
Port From (https://github.com/TrinityCore/TrinityCore/commit/3ff61beafa9f028e582c4d810b93352aa85b18a7)
2021-06-23 12:03:39 -04:00
hondacrx b45e18585f Core/Player: Pass correct Zone ID to HandlePlayerLeaveZone
Port From (https://github.com/TrinityCore/TrinityCore/commit/78577afa4900a0b83c9f33e5f94f15f9f51de8c7)
2021-06-23 12:02:41 -04:00
hondacrx 6dabdfa3ed Core/Scripts: fix some spells double dipping from done/taken bonuses
Port From (https://github.com/TrinityCore/TrinityCore/commit/bb7869b31fc2fe6eb8cd9552249fea028d08316a)
2021-06-23 12:01:41 -04:00
hondacrx 9fd7c12094 Misc updates 2021-06-23 12:01:28 -04:00
hondacrx b70086db18 Core/Unit: check remaining instead of full duration for Bounced by DR auras
Port From (https://github.com/TrinityCore/TrinityCore/commit/d0fa8c72a3c2f82ed49c47f2f1e29618d6ef6abb)
2021-06-22 20:56:13 -04:00