Commit Graph

439 Commits

Author SHA1 Message Date
hondacrx 0b3177fc1f Core/Spells: register and apply individual aura effects on hit handler
Port From (https://github.com/TrinityCore/TrinityCore/commit/c07b9188dfc6f76bd909eea7cb8f5a8263b0e83e)
2021-09-08 22:55:23 -04:00
hondacrx f9779537a8 Core/Spells: Fix periodic rolling adding bonuses twice
Port From (https://github.com/TrinityCore/TrinityCore/commit/9fa95b4b57c1d843392d0c321cdabbc3a21e1d69)
2021-09-08 22:52:23 -04:00
hondacrx 5c4a7511ff Core/Spells: Cleanup spell effects
Port From (https://github.com/TrinityCore/TrinityCore/commit/8a4e1119ac21e2d1112d1717337597fe073e495f)
2021-09-08 17:40:50 -04:00
hondacrx cdd34e644a Fixes loading into server/creating new character. 2021-08-31 13:20:06 -04:00
hondacrx 4e03358392 Core/Spells: Remove outdated damage calculations from Spell::EffectSchoolDMG and Spell::EffectWeaponDmg
Port From (https://github.com/TrinityCore/TrinityCore/commit/6031b95ea717214afb369782337c7e52f6587af6)
2021-08-30 16:29:23 -04:00
hondacrx 02f1211445 Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
Port From (https://github.com/TrinityCore/TrinityCore/commit/3dd75a49b190098010803014072c0c8bee2996bd)
2021-08-30 15:55:48 -04:00
hondacrx 6e9451082d Core/Spells: Refactor building SMSG_SPELL_EXECUTE_LOG to not create 192 empty vectors on every spell cast
Port From (https://github.com/TrinityCore/TrinityCore/commit/bc2c76a5b8b4a6e5c1d6e65d367c700e4ef1cbf2)
2021-08-30 15:46:45 -04:00
hondacrx 85f7edc339 Misc fixes. 2021-08-29 18:46:18 -04:00
hondacrx 949d4806c5 Core/Spells: rework part 5: GameObject casting
Port From (https://github.com/TrinityCore/TrinityCore/commit/962f6d7988b9003e550f6745be7cff812e9d8efa)
2021-08-29 18:27:08 -04:00
hondacrx e97ffa304d Core/Spells: rework part 4: iterate over effects first
Port From (https://github.com/TrinityCore/TrinityCore/commit/65dca120d34febdaa84a63e17f638ab0fa59b3df)
2021-08-28 22:35:39 -04:00
hondacrx 091272755c Core/Spells: rework part 3: spells only handle at most one UnitAura and one DynObjAura during its lifetime
Port From (https://github.com/TrinityCore/TrinityCore/commit/f3548d45d0a74203ef6f5c7282c31ba794ddf7a1)
2021-08-28 17:03:47 -04:00
hondacrx 5ff5fb7d3f Core/Spells: rework part 2: Split up target selection logic
Port From (https://github.com/TrinityCore/TrinityCore/commit/52ae3c89d1d4dbcff309d940fd41c7212edc77b7)
2021-08-28 14:40:52 -04:00
hondacrx 9123dec4b9 Core/Spells: rework part 1: Improved positive detection logic
Port From (https://github.com/TrinityCore/TrinityCore/commit/1e1415a49128d034c8d48aa8cbb5d157200371b0)
2021-08-28 13:56:32 -04:00
hondacrx 663f082640 Some Cleanups from porting. 2021-08-23 14:29:45 -04:00
hondacrx f639a44707 Core/Spells: explicitly disable non proccing auras when generating default procs
Port From (https://github.com/TrinityCore/TrinityCore/commit/0ae1ebedfee41662df5ec49ae2b40670aaea9665)
2021-08-20 19:05:59 -04:00
hondacrx 9947e778b7 Core/Auras: remove too strict checks in area auras, since a few aren't owned by its caster
Port From (https://github.com/TrinityCore/TrinityCore/commit/95c8eae12340d2df59d63c7f67874d21af46a171)
2021-08-20 18:55:14 -04:00
hondacrx 14392fe24c Core/Auras: fixed SPELL_AURA_MOD_HIT_CHANCE honoring stack rules in all cases
Port From (https://github.com/TrinityCore/TrinityCore/commit/b0a05812d23aa1ebe69045243233a5eaba064f11)
2021-08-20 18:51:50 -04:00
hondacrx 936f9d4d93 Core/Auras: added sanity checks for area auras having a different owner unit than caster
Port From (https://github.com/TrinityCore/TrinityCore/commit/6c642f33b58ce81eb5b1345a7f0eb89de6040251)
2021-08-20 18:50:01 -04:00
hondacrx c3367b7508 Core/Spells Implement targets 133, 134, 135 : TARGET_UNIT_LINE_CASTER_TO_DEST_***
Port From (https://github.com/TrinityCore/TrinityCore/commit/fb6761c273d518eae6bab72fc9c2a2b6f93eec83)
2021-08-15 09:05:23 -04:00
hondacrx 9e7116f4de Fixed hunter auto attack. 2021-08-09 14:40:58 -04:00
hondacrx 06fe13fbab Core/VMap: Add outdoor state to Map::GetFullTerrainStatusForPosition. Add WorldObject::IsOutdoors, basic member access.
Port From (https://github.com/TrinityCore/TrinityCore/commit/e47e95b6dc89a7332ae4d5d833639e4f30f3d8c5)
2021-08-09 11:33:30 -04:00
hondacrx a2628af13a Core/Auras: check conditions against referer caster, just as spells do
Port From (https://github.com/TrinityCore/TrinityCore/commit/ffa359c21cf92810d2c927496749148ff6ea9042)
2021-08-09 10:00:05 -04:00
hondacrx bfd44a494d Core/Auras: restrict target map update only to area auras as player requires to have auras registered on load
Port From (https://github.com/TrinityCore/TrinityCore/commit/8e7a12a87aa6502b7bf9adc42478283859f9268a)
2021-08-09 09:25:37 -04:00
hondacrx 26a2eced6e Core/Auras: fixed Drain Mana breaking early if caster has Mana Feed talent but no active pet
Port From (https://github.com/TrinityCore/TrinityCore/commit/64399f58a37e0c2633d986af6af781e7f7b15998)
2021-08-08 23:33:31 -04:00
hondacrx 89bd0b003d Core/Spells: Execute item casts immediately instead
Port From (https://github.com/TrinityCore/TrinityCore/commit/64234b35ede0ec6e12048ec9a3dc8ae438ddb6e4)
2021-08-08 23:32:08 -04:00
hondacrx dac2b45ab8 Partial: Core/Entities: Reduce the probability of units dropping under the map
Port From (https://github.com/TrinityCore/TrinityCore/commit/69edf282fa777912385dbb4d921b9f3a8f92a00e)
2021-08-08 23:16:19 -04:00
hondacrx 7ffe2ee299 Core/Spells: Use caster as chat source in Spell::EffectSendChatMessage
Port From (https://github.com/TrinityCore/TrinityCore/commit/fcead0b4eae298c1a46c42fea56a3b3b9ae2bf8f)
2021-08-08 14:57:54 -04:00
hondacrx 7ca12d9793 Core/DataStores: 9.1.0 db2 structures
Port From (https://github.com/TrinityCore/TrinityCore/commit/ce1046a8fd0f04aad6c414786949269fffea88f3)
2021-08-08 14:40:42 -04:00
hondacrx 001b026bce Core/Auras: Fix incorrect use of GetUnitOwner() in DynObjAura::FillTargetMap
Port From (https://github.com/TrinityCore/TrinityCore/commit/07f51437fc9ddba2810c090caa76ab294bcf777b)
2021-07-22 07:47:40 -04:00
hondacrx 4b142a08bd Core/Auras: Skip estimated points calculation for SPELL_EFFECT_PERSISTENT_AREA_AURA
Port From (https://github.com/TrinityCore/TrinityCore/commit/515d3da181e105aceeba02d8dab46454be00f433)
2021-07-21 15:51:43 -04:00
hondacrx 50fcbd3aaf Some cleanups 2021-07-08 13:01:46 -04:00
hondacrx 868bbf9edd Fixes a Assert with calling GetUnitOwner when aura is a DynObjAura.
Not sure if this is the right fix, or if there is more places it should be changed.
2021-07-03 20:42:57 -04:00
hondacrx 8418528bb0 oops 2021-07-01 00:07:54 -04:00
hondacrx cc192de659 Some missed changes. 2021-06-30 23:36:22 -04:00
hondacrx 1d9e839bc9 Core/Auras: remove obsolete check that was preventing some auras to proc even if they met conditions otherwise
Port From (https://github.com/TrinityCore/TrinityCore/commit/1fe817a9957bdc62d1e9a0b33f4615746831a6a7)
2021-06-23 23:51:38 -04:00
hondacrx eefb63647d Core/Spells: prevent creatures to focus channeled spells without SPELL_ATTR1_CHANNEL_TRACK_TARGET
Port From (https://github.com/TrinityCore/TrinityCore/commit/d91e099b10a33d9205c023c81bcc966d713c39ab)
2021-06-23 23:43:18 -04:00
hondacrx 5bbd708070 Core/Auras: make area and dynauras condition compliant by using the spellarea searcher instead of script searchers
Port From (https://github.com/TrinityCore/TrinityCore/commit/1f3e365ff6c010424746f34104d1228fb6a96b8a)
2021-06-23 23:23:48 -04:00
hondacrx 237b583e64 Core/Spells: fixed server being too overzealous with autoshot
Port From (https://github.com/TrinityCore/TrinityCore/commit/5323a7d38697967c12abe9b2903b97e271a2cac1)
2021-06-23 23:13:05 -04:00
hondacrx fbec933705 Core/Unit: kill unused parameter from SpellxxxBonusTaken
Port From (https://github.com/TrinityCore/TrinityCore/commit/15810eb579c40ee2b3db35ef2a99b7c5cb70c985)
2021-06-23 22:27:20 -04:00
hondacrx 1be1a5ad1a Core/Spells: add log on load about improper use of attribute PROC_ATTR_REQ_SPELLMOD
Port From (https://github.com/TrinityCore/TrinityCore/commit/3582bacc4a3550725d288b55fb16311dee0ae0df)
2021-06-23 22:13:19 -04:00
hondacrx 1b87be93be Core/Spells: implement SPELLVALUE_CRIT_CHANCE
Port From (https://github.com/TrinityCore/TrinityCore/commit/13be704cb4619ef585ae0043580e2534f62e64aa)
2021-06-23 22:09:38 -04:00
hondacrx 9e23ca4b04 Core/Spells: calculate crit chance only for spells that do damage/healing
Port From (https://github.com/TrinityCore/TrinityCore/commit/85e5509e91a1370b16851d375a26121797870921)
2021-06-23 22:06:49 -04:00
hondacrx 11cbb26bc1 Core/Auras: fix periodic ticks proc after previous commit
Port From (https://github.com/TrinityCore/TrinityCore/commit/c21dc3c1b7985cbffaaf1cd17a48bddd2106154d)
2021-06-23 17:42:38 -04:00
hondacrx 0daea24b3f Core/Spells: require phasemask set for periodic damage procflag
Port From (https://github.com/TrinityCore/TrinityCore/commit/91fa279bdf67646ab15601ec18096c0a45133ebf)
2021-06-23 17:40:28 -04:00
hondacrx f959a0fd91 Core/Spells: fix logic error causing near teleports to drop combat for players
Port From (https://github.com/TrinityCore/TrinityCore/commit/8c379e920ca184d520c81ada26c42c5dfeac770d)
2021-06-23 16:02:44 -04:00
hondacrx 9d3cd6a6e5 Core/Spells: fix logic error causing near teleports to drop combat for players
Port From (https://github.com/TrinityCore/TrinityCore/commit/f9b14ca795de932746ce404dfe56c5cded3bde2b)
2021-06-23 15:59:06 -04:00
hondacrx abee68a7ee Core/Spells: remove duplicated LowerPlayerDamageReq call on reflected spells
Port From (https://github.com/TrinityCore/TrinityCore/commit/800d92bec3b7a771f6fbd8d123dc727c54becd4b)
2021-06-23 15:54:43 -04:00
hondacrx 619c79e7f1 Core/Spells: fix SPELLMOD_DAMAGE application order for melee spells
Port From (https://github.com/TrinityCore/TrinityCore/commit/d34292534c197887cd33c15ff98ca8c96dc4fb99)
2021-06-23 15:43:29 -04:00
hondacrx b012517079 Core/Spells: kill unused parameter from Spell constructor
Port From (https://github.com/TrinityCore/TrinityCore/commit/01d9306854618bb66f79e1f0f5d9781ff48ab019)
2021-06-23 15:37:52 -04:00
hondacrx 51a6d72fd4 Spell/Script: Torch 52953 and 58121 must hit only one target
Port From (https://github.com/TrinityCore/TrinityCore/commit/854abdbfb6ea1075fbe5db09c1ce70aa2bdb18a8)
2021-06-23 15:30:08 -04:00