Commit Graph

943 Commits

Author SHA1 Message Date
hondacrx 55c298be9f Core/Misc: Various dynspawn cleanup and refactors split off from pooling rewrite:
Port From (https://github.com/TrinityCore/TrinityCore/commit/eee950cdd7bcbe9443a53ea5c4cce35444a503f7)
2021-12-27 18:09:58 -05:00
hondacrx 9b2d1e67b6 Core/Spawns: Exterminate CONFIG_SAVE_RESPAWN_TIME_IMMEDIATELY with extreme prejudice. (It didn't work anyway.)
Port From (https://github.com/TrinityCore/TrinityCore/commit/d5e58cef694d3db65f0a27b93099ae4e517685a4)
2021-12-27 17:39:42 -05:00
hondacrx 12f472cee1 Core/Chat: Rewrite some custom channel handling. Channel creation now properly saves passwords.
Port From (https://github.com/TrinityCore/TrinityCore/commit/ea753efb9370455979c8af8ebaafa734b77d6052)
2021-12-27 17:23:39 -05:00
hondacrx 5e193139a2 Core/Unit: movement related corrections prior to getting Charmed
Port From (https://github.com/TrinityCore/TrinityCore/commit/ef6a5d3c3c010f9ad63a71015a533a3894ab38b9)
2021-12-27 17:10:23 -05:00
hondacrx c209f30475 Battleground/Arena: Properly check RBAC arena join permission before allowing queue.
Port From (https://github.com/TrinityCore/TrinityCore/commit/a69a061d76fe4e142e84c775230e2fcbd6ddb9d4)
2021-12-27 17:06:18 -05:00
hondacrx 0dda317989 Core/Quest: Do not allow quests to be turned in if the player no longer satisfies level/skill/reputation requirements.
Port From (https://github.com/TrinityCore/TrinityCore/commit/925aaecbc0997a8fa3dea8de25f12258f889ffad)
2021-12-27 16:50:14 -05:00
hondacrx 8e06e237e0 Entities/Player: Properly restore PvP-enabled state on login
Port From (https://github.com/TrinityCore/TrinityCore/commit/a5d8807af8cb0f257f81fa5cf3ac70769b677575)
2021-12-27 16:33:10 -05:00
hondacrx 828fafbcc8 Entities/Unit: Nuke Map::ForceRespawn from orbit, with the following implications:
Port From (https://github.com/TrinityCore/TrinityCore/commit/2532de6acb7d73957a8fca44e7fc26160f47cc47)
2021-12-27 16:29:29 -05:00
hondacrx a693bed211 Entities/Creature: Some asserts are now LOG_ERRORs that block spawning. Fix a group spawning bug exposed by the CoS merge. Improve some command output.
Port From (https://github.com/TrinityCore/TrinityCore/commit/2225cb120100da741814dec7515b191cc68f07be)
2021-12-27 15:51:24 -05:00
hondacrx dfcdade81a Core/Vehicle: prevent creature vehicles from following their old movement generator when a player enters them in some cases.
Port From (https://github.com/TrinityCore/TrinityCore/commit/24c07367f109aa19a51defdf77c50d389ed90845)
2021-12-27 15:40:37 -05:00
hondacrx c154984847 Core/Quest: fix icon in gossip window for repeatable, non-autocomplete quests.
Port From (https://github.com/TrinityCore/TrinityCore/commit/004602f3e4ece8ee601c09d869f1531518313c94)
2021-12-27 15:37:55 -05:00
hondacrx dafb8637d9 Core/Entities: Regenerate updatefields
Port From (https://github.com/TrinityCore/TrinityCore/commit/776298207a9522858af7b00ea2f5b0c65bbe049e)
2021-12-27 15:27:41 -05:00
hondacrx 6396bbca38 Core/Creature: Reworked creature aggro radius calculation
Port From (https://github.com/TrinityCore/TrinityCore/commit/3fc20584bc14ca0edb007b3d0b6861d19d6d33d4)
2021-12-27 15:25:53 -05:00
hondacrx 7a47eaeb24 Core/Conditions: allow spellclick conditions to properly work for aura apply/remove
Port From (https://github.com/TrinityCore/TrinityCore/commit/edf12fd6a1b989d7785bc0619002eda1ccc87368)
2021-12-27 15:23:22 -05:00
hondacrx 08678c970e Core/Unit: Implement more helper methods
Port From (https://github.com/TrinityCore/TrinityCore/commit/104ec7a81a5bb782f81fd05b872bf664e4de1c89)
2021-12-26 20:04:34 -05:00
hondacrx 55189b9395 Core/Quest: Fix repeatable quest mark
Port From (https://github.com/TrinityCore/TrinityCore/commit/c5173aca15fcabba9ffce6393cf17868dc30750f)
2021-12-26 19:59:39 -05:00
hondacrx a3f2e9f372 Entities/Player: Fix an edge case where overlapping CCs could prevent player movement from being re-enabled.
Port From (https://github.com/TrinityCore/TrinityCore/commit/096269349cd82a44f57f36b17dfe4e5e32a39f9a)
2021-12-26 19:56:01 -05:00
hondacrx bddde92a0f Entities/Player: Clean up client control handling behavior around possession. Mind Control should no longer cause various weirdness.
Port From (https://github.com/TrinityCore/TrinityCore/commit/bba4696de715b79b31e154d1a8e1597507812ece)
2021-12-26 19:54:55 -05:00
hondacrx 6d73a59f63 Core/Player: add helper methods GetNativeGender/SetNativeGender/SetGender
Port From (https://github.com/TrinityCore/TrinityCore/commit/27886c7f5d6cfc221ea67aab210f96859d725e05)
2021-12-26 19:51:26 -05:00
hondacrx ce3b99471d Core/Quest: do not send SMSG_QUESTGIVER_OFFER_REWARD right after SMSG_QUESTGIVER_QUEST_FAILED.
Port From (https://github.com/TrinityCore/TrinityCore/commit/ecce30a8072fd9352edae378a182f6bf6619d412)
2021-12-26 19:32:56 -05:00
hondacrx 73fa489610 Misc: some corrections after recent merges
Port From (https://github.com/TrinityCore/TrinityCore/commit/cadbf42ea4489933f28caf356f8c8d09ca243083)
2021-12-24 21:38:37 -05:00
hondacrx 5c41122916 Core/GameObject: do not allow consumable chests to restock while partially looted.
Port From (https://github.com/TrinityCore/TrinityCore/commit/2fea2a1e8104856587d0eff651eb2199dfcd0513)
2021-12-24 21:22:21 -05:00
hondacrx 5c4a42317e Core/GameObject: fix some cases where summoned gameobjects of a type different than chest or goober would behave wrongly.
Port From (https://github.com/TrinityCore/TrinityCore/commit/f136d3cfe0e92ac8578c631cc7c2c43086ba796f)
2021-12-24 21:20:14 -05:00
hondacrx 2a9a1a1d6b Core/GameObject: implement restock mechanic for non-consumable gameobjects
Port From (https://github.com/TrinityCore/TrinityCore/commit/c637260a37271a9ed2b19d44a62210e833010bde)
2021-12-24 21:14:21 -05:00
hondacrx 85d81d39fc Core/GameObject: restore old behavior for non-consumable chests with restock timer (make them despawn).
Port From (https://github.com/TrinityCore/TrinityCore/commit/7c7bb95da58bc9621f293c1c4d560f426ae0df64)
2021-12-24 21:08:08 -05:00
hondacrx 445b24188f Core/GameObject: don't allow non-consumable goobers to despawn on use
Port From (https://github.com/TrinityCore/TrinityCore/commit/836a1bc62272861a595b339345eb1ac67c543c5b)
2021-12-24 21:07:14 -05:00
hondacrx a75bc5188f Core/Spell: allow damage from binary spells to go through elemental resistance's damage reduction.
Port From (https://github.com/TrinityCore/TrinityCore/commit/09e849bb69561fe91a9b8c1aa72555eb6c65d0b2)
2021-12-24 21:05:41 -05:00
hondacrx b3759bb7b0 Core/SAI: do not pass old creatureData to UpdateEntry() and keep current health when changing a NPC's entry.
Port From (https://github.com/TrinityCore/TrinityCore/commit/62f5d9b46bd20faf90dd973e2786d1517b1b3bd2)
2021-12-24 20:57:58 -05:00
hondacrx 31e0a1f476 Core/Spells: Moved SpellVisual functions from Unit to WorldObject
Port From (https://github.com/TrinityCore/TrinityCore/commit/54f607641ac9008a588b8ff635a9ed7ee7a5f976)
2021-12-24 20:50:24 -05:00
hondacrx 5de09a5046 Core/BattlePets: Added default cooldown to revive battle pets
Port From (https://github.com/TrinityCore/TrinityCore/commit/1a846415493289fc3852e56c82514d85c421267c)
2021-12-24 20:41:51 -05:00
hondacrx 3cf7f6b831 Combat/Threat: Split ThreatManager::NotifyDisengaged off from ThreatManager::ClearAllThreat. NotifyDisengaged signifies intent to clear the engagement flag, and should only be called from AI.
Port From (https://github.com/TrinityCore/TrinityCore/commit/38d7c1530a65a7ff1bd10775c4a35269b2416538)
2021-12-24 20:15:10 -05:00
hondacrx e28b42b270 Entities/Unit: Fix an issue where Unit pointers could be left dangling if a channeled Charm was interrupted by a control aura application.
Port From (https://github.com/TrinityCore/TrinityCore/commit/d10554da14fb8371072567f673c9f919cbe6b929)
2021-12-23 20:19:55 -05:00
hondacrx 1f58dc2b53 Entities/Unit: Cleanup all the direct accesses to m_unitMovedByMe. Refactor the field to be protected. Add assertions to catch dangling pointers.
Port From (https://github.com/TrinityCore/TrinityCore/commit/edc75831194bc2419e3abada47121fadf4b2aa8d)
2021-12-23 20:17:08 -05:00
hondacrx 4584543d45 some more cleanup
Port From (https://github.com/TrinityCore/TrinityCore/commit/f29644efd5cf430c321ad68122c385b4535069da)
2021-12-23 20:03:50 -05:00
hondacrx cd1edd609f Core/Creature: Attach out-of-combat health regen to the Engaged system, not the Combat flag.
Port From (https://github.com/TrinityCore/TrinityCore/commit/e3411b4740be2241c49361f9f6223f52f4389c7d)
2021-12-23 20:03:03 -05:00
hondacrx 749b77d060 Core/Misc: Rename Unit::AttackedTarget to Unit::AtTargetAttacked to match naming scheme for these notifiers
Port From (https://github.com/TrinityCore/TrinityCore/commit/dabdad3b47d7438327d3ee861eddd68e9bea68b1)
2021-12-23 20:02:14 -05:00
hondacrx 8694a2ae24 Core/Entities: Kick engagement logic upstairs to Unit (from ThreatManager), since all Units with AI need it (not just those with threat list).
Port From (https://github.com/TrinityCore/TrinityCore/commit/35e55f10899712435102764671241b94a2026599)
2021-12-23 20:00:45 -05:00
hondacrx 8b23a77c5f Core/Loot: don't allow to regenerate chest loot inside instances and raids.
Port From (https://github.com/TrinityCore/TrinityCore/commit/bfef73b5102201e85a31b39ae595da42d9750c7e)
2021-12-22 20:32:04 -05:00
hondacrx 8510f01035 Misc fixes 2021-12-22 20:23:48 -05:00
hondacrx 3bae896803 Core/Loot: fix some other cases where a creature should not be able to set focus.
Port From (https://github.com/TrinityCore/TrinityCore/commit/3278f87789b8357ce888ab61026c0ca6daa8e6cb)
2021-12-17 19:41:25 -05:00
hondacrx fc95164995 Core/Unit: Ignore On Transport spline movements if the Unit isn't on a transport anymore
Port From (https://github.com/TrinityCore/TrinityCore/commit/134fa225108381969b4a7dc22b4a3076a79c21f6)
2021-12-17 19:39:58 -05:00
hondacrx 85f24d047e Core/Player: Fix teleporting FlyPath dismounting the player
Port From (https://github.com/TrinityCore/TrinityCore/commit/2d7ec53330bda17704cf46a88785f40b95ce3bfb)
2021-12-17 19:37:23 -05:00
hondacrx 1bd33fce8e Core/Loot: implement automatic pass in group loot for items that cannot be looted.
Port From (https://github.com/TrinityCore/TrinityCore/commit/1c8f94a14f51e5ddfd0eb277e2b709da274e654d)
2021-12-17 19:33:22 -05:00
hondacrx b349f922b2 Core/Spells: don't allow spells with SPELL_EFFECT_CREATE_LOOT to be cast if there isn't enough space in inventory
Port From (https://github.com/TrinityCore/TrinityCore/commit/59da957165ef7d7529db30f90a30dc401d682052)
2021-12-17 19:26:43 -05:00
hondacrx 112803c149 Core/Creature: prevent dead creatures from setting a focus target, so they won't turn when hit by certain spells.
Port From (https://github.com/TrinityCore/TrinityCore/commit/264373bb656352a0cdf9b18bad4f3929c7376a9c)
2021-12-17 19:17:29 -05:00
hondacrx 613fa25096 Core/Player: allow AutoStoreLoot to specify if the looted item should be shown as if created by the player.
Port From (https://github.com/TrinityCore/TrinityCore/commit/81a8366ce5659f3556a0b910a0437256d95b62f9)
2021-12-17 17:47:14 -05:00
hondacrx b84f88d98f Core/Player: Remove all Motion Masters when teleporting
Port From (https://github.com/TrinityCore/TrinityCore/commit/ab3edebb5d824f7cb0d030daba168e2bb7900511)
2021-12-17 17:44:45 -05:00
hondacrx da41af6279 Core/BattlePets: Improvements when enabling battle pets
Port From (https://github.com/TrinityCore/TrinityCore/commit/0a8f79ad5ad5afbf6a6aedc9ad46c3b774877b31)
2021-12-16 13:10:24 -05:00
hondacrx f7023cb290 Core/Spells: Implemented SPELL_ATTR1_CAST_WHEN_LEARNED
Port From (https://github.com/TrinityCore/TrinityCore/commit/747da1f804a05462fb0d542a9570f27a549688dc)
2021-12-16 13:00:53 -05:00
hondacrx 599eb14a16 Core/Map: Don't log errors about Area ID 0
Port From (https://github.com/TrinityCore/TrinityCore/commit/efbb6f5b7d66c31671aed47881825b6baa6f5019)
2021-12-16 12:59:09 -05:00